PMM-7: Fix disabled CGO_ENABLED in release builds #1142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoqo
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
BupycHuk
approved these changes
Aug 12, 2025
BupycHuk
reviewed
Aug 12, 2025
.github/workflows/go.yml
Outdated
Comment on lines
69
to
72
| - name: Dry-run GoReleaser | ||
| run: | | ||
| make release-dry-run | ||
|
|
There was a problem hiding this comment.
it will run on every matrix element which isn't great, let's make another job and rename current one to test instead of build
There was a problem hiding this comment.
yeah reworked them now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.